Skip to content

Read current strategies in switch console#15

Merged
Pigbibi merged 1 commit into
mainfrom
codex/dynamic-current-strategy
Jun 8, 2026
Merged

Read current strategies in switch console#15
Pigbibi merged 1 commit into
mainfrom
codex/dynamic-current-strategy

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • read current GitHub Variables for signed-in switch-console users
  • prefer account-specific service target records before runtime target and strategy profile fallbacks
  • allow dynamically read strategy profiles to appear in the strategy dropdown
  • align default account profiles with current platform records and document the strategy profile catalog rule

Tests

  • sed -n '/<script>/,/<\/script>/p' web/strategy-switch-console/index.html | sed '1d;$d' | node --check --input-type=commonjs
  • node --check --input-type=module < web/strategy-switch-console/page_asset.js
  • node --check --input-type=module < web/strategy-switch-console/worker.js
  • python3 scripts/runtime_settings.py validate
  • python3 -m unittest discover -s tests -v
  • git diff --check

@Pigbibi Pigbibi force-pushed the codex/dynamic-current-strategy branch from e254786 to c00c64f Compare June 8, 2026 21:04

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e2547869cc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +434 to +435
const token = env.RUNTIME_SETTINGS_DISPATCH_TOKEN;
if (!token || !accountOptions) return {};

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Require token access for target variables

When the Worker is configured as documented with RUNTIME_SETTINGS_DISPATCH_TOKEN only able to dispatch workflows in QuantRuntimeSettings, this new read path silently gets 403s for the platform repositories and /api/config never shows the current strategies. The feature now depends on the server token also having Actions-variable read access to each target repo/environment, so either the required scope/secret needs to change or a separate read-capable token should be used here.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi merged commit d510739 into main Jun 8, 2026
2 checks passed
@Pigbibi Pigbibi deleted the codex/dynamic-current-strategy branch June 8, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant